Bug 21270

Summary:

Avoid unnecessary copy of params for no-param functions that don't use "this"

Product:

WebKit

Reporter:

Maciej Stachowiak <mjs>

Component:

JavaScriptCore

Assignee:

Maciej Stachowiak <mjs>

Status:

RESOLVED WORKSFORME

Severity:

Normal

CC:

barraclough

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
first attempt - not clear if it has the desired perf benefit	none

Maciej Stachowiak

Reported 2008-10-01 02:36:36 PDT

When a function that has no formal parameters, and which does not use "this", is called with too many arguments, it is not necessary to copy the arguments and build a second call frame. Avoiding this should lead to a speedup.

Attachments
first attempt - not clear if it has the desired perf benefit (22.64 KB, patch) 2008-10-01 02:38 PDT, Maciej Stachowiak	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Maciej Stachowiak

Comment 1 2008-10-01 02:38:34 PDT

Created attachment 23973 [details] first attempt - not clear if it has the desired perf benefit

Maciej Stachowiak

Comment 2 2008-10-01 12:31:52 PDT

Comment on attachment 23973 [details] first attempt - not clear if it has the desired perf benefit I did not mean to flag this for review.

Gavin Barraclough

Comment 3 2012-09-06 23:42:25 PDT

I think this case has been covered by revering the arguments – we now only need to fixup the arguments if too few are passed.

Note You need to log in before you can comment on or make changes to this bug.