Bug 212648

Summary: Pass WebPageProxyIdentifier to PreconnectTask
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2020-06-02 11:06:17 PDT
Pass WebPageProxyIdentifier to PreconnectTask
Attachments
Patch (7.48 KB, patch)
2020-06-02 11:07 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (7.67 KB, patch)
2020-06-02 11:24 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (7.69 KB, patch)
2020-06-02 17:56 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-06-02 11:07:59 PDT
Created attachment 400843 [details] Patch
Chris Dumez
Comment 2 2020-06-02 11:16:52 PDT
Comment on attachment 400843 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400843&action=review > Source/WebKit/NetworkProcess/NetworkProcess.cpp:1410 > + parameters.webPageProxyID = webPageProxyID; It would be good to set loadParameters.webPageID too.
Alex Christensen
Comment 3 2020-06-02 11:24:24 PDT
Created attachment 400846 [details] Patch
Chris Dumez
Comment 4 2020-06-02 11:25:08 PDT
Comment on attachment 400846 [details] Patch r=me
Chris Dumez
Comment 5 2020-06-02 11:25:45 PDT
Comment on attachment 400846 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400846&action=review > Source/WebKit/NetworkProcess/NetworkProcess.cpp:1400 > +void NetworkProcess::preconnectTo(PAL::SessionID sessionID, WebPageProxyIdentifier webPageProxyID, WebCore::PageIdentifier pageID, const URL& url, const String& userAgent, WebCore::StoredCredentialsPolicy storedCredentialsPolicy, Optional<NavigatingToAppBoundDomain> isNavigatingToAppBoundDomain) I think we normally call this webPageID instead of pageID nowadays.
Alex Christensen
Comment 6 2020-06-02 17:56:10 PDT
Created attachment 400869 [details] Patch
EWS
Comment 7 2020-06-03 08:37:54 PDT
Committed r262487: <https://trac.webkit.org/changeset/262487> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400869 [details].
Radar WebKit Bug Importer
Comment 8 2020-06-03 08:38:16 PDT
<rdar://problem/63928386>
Note You need to log in before you can comment on or make changes to this bug.