Bug 212612

Summary: Revise PVRTC compressed texture validation in ANGLE backend for WebGL
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, graouts, jdarpinian, justin_fan, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 212240    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Kenneth Russell
Reported 2020-06-01 14:20:56 PDT
While upstreaming the fix for Bug 212240 into ANGLE in http://anglebug.com/4652 , some errors were discovered in the size validation for these compressed textures. To simplify identifying these fixes, the PVRTC validation in WebKit's copy of ANGLE should be updated with them separately.
Attachments
Patch (8.62 KB, patch)
2020-06-01 14:23 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Patch (8.73 KB, patch)
2020-06-01 19:39 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2020-06-01 14:23:41 PDT
Created attachment 400759 [details] Patch
Kenneth Russell
Comment 2 2020-06-01 14:24:09 PDT
Note: holding off requesting commit queue until the upstream patch has been reviewed and landed in ANGLE.
EWS Watchlist
Comment 3 2020-06-01 14:24:31 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Kenneth Russell
Comment 4 2020-06-01 16:24:05 PDT
Comment on attachment 400759 [details] Patch Removing review bit - sorry, didn't run the S3TC tests locally, so clearly there's a bug.
Kenneth Russell
Comment 5 2020-06-01 19:39:00 PDT
Created attachment 400777 [details] Patch
Dean Jackson
Comment 6 2020-06-02 16:06:48 PDT
Checked on iOS hardware.
EWS
Comment 7 2020-06-02 16:18:07 PDT
Committed r262460: <https://trac.webkit.org/changeset/262460> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400777 [details].
Radar WebKit Bug Importer
Comment 8 2020-06-02 16:19:16 PDT
<rdar://problem/63897758>
Kenneth Russell
Comment 9 2020-06-02 16:26:05 PDT
Thanks Dean for validating this on iOS hardware!
Note You need to log in before you can comment on or make changes to this bug.