Bug 212603

Summary: x86.rb's LabelReference.x86LoadOperand()'s address operand should be a pointer type.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. saam: review+

Mark Lam
Reported 2020-06-01 12:19:13 PDT
The current implementation mistakenly sets the address type to that of the value being loaded.
Attachments
proposed patch. (1.69 KB, patch)
2020-06-01 12:23 PDT, Mark Lam 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2020-06-01 12:23:04 PDT
Created attachment 400746 [details] proposed patch.
Yusuke Suzuki
Comment 2 2020-06-01 12:35:17 PDT
Comment on attachment 400746 [details] proposed patch. r=me too
Mark Lam
Comment 3 2020-06-01 12:36:35 PDT
Thanks for the review. Landed in r262389: <http://trac.webkit.org/r262389>.
Radar WebKit Bug Importer
Comment 4 2020-06-01 12:37:18 PDT
<rdar://problem/63839299>
Note You need to log in before you can comment on or make changes to this bug.