Bug 212583

Summary: REGRESSION[r260844]: [GTK][WPE] Inspector GResource no longer updated after WebInspectorUI file updates
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, bugs-noreply, cgarcia, chris.reid, don.olmstead, dpino, ews-watchlist, fujii.hironori, gyuyoung.kim, jmason, mcatanzaro, ryuan.choi, sergio, stephan.szabo
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 210942    
Bug Blocks:    
Attachments:
Description Flags
patch none

Philippe Normand
Reported 2020-05-31 10:17:39 PDT
+++ This bug was initially created as a clone of Bug #210942 +++ Reproducer: 1. Full clean GTK build from scratch 2. Edit GraphicsTabContentView.js, change the tabIcon to Gear.svg 3. Update your build 4. Start Minibrowser, open WebInspector Expected result: The graphics tab uses the gear icon Current result: The graphics tab uses the graphics icon Workaround: to force an update of the GResource: find WebKitBuild/ -name InspectorGResourceBundle.xml -exec rm {} \; and then rebuild... I've tried to revert r260844, doesn't change anything...
Attachments
patch (1.49 KB, patch)
2020-06-02 16:10 PDT, Christopher Reid 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Christopher Reid
Comment 1 2020-06-02 16:10:18 PDT
Created attachment 400865 [details] patch This seems to fix the problem, the dependency on the WebInspectorUI target wasn't enough to trigger rebuilds. I've also tried clean GTK builds to make sure this works.
EWS
Comment 2 2020-06-02 17:58:00 PDT
Committed r262466: <https://trac.webkit.org/changeset/262466> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400865 [details].
Note You need to log in before you can comment on or make changes to this bug.