Bug 212515
| Summary: | Adjust <link rel=stylesheet disabled> handling | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Anne van Kesteren <annevk> |
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ahmad.saleem792, bfulgham, cyb.ai.815, emilio, mike, ntim, webkit-bug-importer |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar, WPTImpact |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=243540 https://bugs.webkit.org/show_bug.cgi?id=260642 |
||
Anne van Kesteren
See https://github.com/web-platform-tests/wpt/pull/22645 and https://github.com/whatwg/html/pull/4519.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/96304439>
Brent Fulgham
It looks like we fail a couple of these tests (though we pass most). Importing.
Ahmad Saleem
We are only browser failing but just two tests:
https://wpt.fyi/results/css/cssom?label=master&label=experimental&aligned=&q=cssom%2Fhtmllinkelement-
Ahmad Saleem
Blink Commit - https://chromium-review.googlesource.com/c/chromium/src/+/2216701
sideshowbarker
(In reply to Ahmad Saleem from comment #3)
> We are only browser failing but just two tests:
>
> https://wpt.fyi/results/css/
> cssom?label=master&label=experimental&aligned=&q=cssom%2Fhtmllinkelement-
The patch in https://github.com/WebKit/WebKit/pull/17001 gets WebKit passing all those tests.
But that patch isn’t a full implementation of the spec requirements in https://github.com/whatwg/html/pull/4519.
I have a separate patch that implements the “explicitly enabled” boolean flag specified in https://github.com/whatwg/html/pull/4519 — but I don’t yet know how to test it, or if WebKit even needs it.
I say that because HTMLLinkElement-disabled-003.html to HTMLLinkElement-disabled-007.html there all include some tests for the “explicitly enabled” requirements — but since WebKit is already passing all those tests, then it seems like either those tests aren’t correctly testing the “explicitly enabled” requirements, or else the WebKit implementation somehow already conforms to those requirements.
Emilio Cobos Álvarez (:emilio)
The "explicitly enabled" boolean flag is implemented as m_disabledState == EnabledViaScript in WebKit.
sideshowbarker
(In reply to Emilio Cobos Álvarez (:emilio) from comment #6)
> The "explicitly enabled" boolean flag is implemented as m_disabledState ==
> EnabledViaScript in WebKit.
aha, I see now — thanks much
Tim Nguyen (:ntim)
Should this be duped to bug 260642?