| Summary: | Avoid unnecessary sync IPC messages when togging the callout bar for selections | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> | ||||||
| Component: | New Bugs | Assignee: | Megan Gardner <megan_gardner> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | thorton, webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Megan Gardner
2020-05-28 19:22:20 PDT
Created attachment 400537 [details]
Patch
Comment on attachment 400537 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400537&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2566 > + if (!_page->editorState().selectionIsRange) > + return NO; > + if ([self _pointIsInsideSelectionRect:point outBoundingRect:nil]) > + return YES; > + return NO; Nit - I would just write this `return [self _pointIsInsideSelectionRect:point outBoundingRect:nil];`. Comment on attachment 400537 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400537&action=review > Source/WebKit/ChangeLog:3 > + Avoid unnessecary sync IPC messages when togging the callout bar for selections. Nit - unnecessary Created attachment 400547 [details]
Patch for landing
Committed r262280: <https://trac.webkit.org/changeset/262280> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400547 [details]. |