Bug 212473

Summary: Implement named item condition for images
Product: WebKit Reporter: Rob Buis <rbuis>
Component: New BugsAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, ews-watchlist, gyuyoung.kim, mjs, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Rob Buis
Reported 2020-05-28 09:53:26 PDT
Implement named item condition for images, not only should we check there are both an id and a name attribute, but also that the name attribute is non-empty: https://html.spec.whatwg.org/multipage/dom.html#dom-document-nameditem-filter
Attachments
Patch (5.31 KB, patch)
2020-05-28 09:57 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2020-05-28 09:57:56 PDT
Created attachment 400473 [details] Patch
Maciej Stachowiak
Comment 2 2020-05-31 03:12:35 PDT
Comment on attachment 400473 [details] Patch r=me
EWS
Comment 3 2020-05-31 03:40:17 PDT
Committed r262360: <https://trac.webkit.org/changeset/262360> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400473 [details].
Radar WebKit Bug Importer
Comment 4 2020-05-31 03:41:22 PDT
<rdar://problem/63805627>
Note You need to log in before you can comment on or make changes to this bug.