| Summary: | Web Inspector: generate_cpp_protocol_types_header.py:294: SyntaxWarning: "is" with a literal. Did you mean "=="? | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||
| Component: | JavaScriptCore | Assignee: | Michael Catanzaro <mcatanzaro> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bburg, ews-watchlist, hi, joepeck, keith_miller, mark.lam, mcatanzaro, msaboff, saam, timothy, tzagallo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Created attachment 400457 [details]
Patch
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`) Committed r262243: <https://trac.webkit.org/changeset/262243> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400457 [details]. |
I just noticed this build warning with python 3.8.3, not sure if it's new or if I've just never noticed before: [155/1729] Generating ../../DerivedSou...spector/InspectorBackendCommands.js.in /home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:294: SyntaxWarning: "is" with a literal. Did you mean "=="? if line.startswith(('#', '/*', '*/', '//')) or len(line) is 0: Fix is trivial.