Bug 212464

Summary: Allow using web processes for service workers even though they loaded about URLs
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, jbedard, Lawrence.j, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=212696
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2020-05-28 06:04:41 PDT
Allow using web processes for service workers even though they loaded about URLs
Attachments
Patch (5.17 KB, patch)
2020-05-28 06:09 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.17 KB, patch)
2020-06-02 08:44 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-05-28 06:09:40 PDT
Created attachment 400448 [details] Patch
youenn fablet
Comment 2 2020-05-28 07:29:00 PDT
Test failures are related to a runtime flag change, this will be fixed at https://bugs.webkit.org/show_bug.cgi?id=212466.
youenn fablet
Comment 3 2020-06-02 04:27:14 PDT
Comment on attachment 400448 [details] Patch This changes also the WebProcessCache, which might be an improvement as well. The case that might need to be dealt with in the future is the case of a tab opening about:blank in another process and then writing data on it. The new process should then have its registrable domain set to the tab opener and I am not sure this is guaranteed now.
Chris Dumez
Comment 4 2020-06-02 08:29:45 PDT
Comment on attachment 400448 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400448&action=review > Source/WebKit/ChangeLog:9 > + A web process that is running service workers and is laoding an about:blank page will also kill its service workers. typo: laoding
youenn fablet
Comment 5 2020-06-02 08:44:19 PDT
Created attachment 400829 [details] Patch for landing
EWS
Comment 6 2020-06-02 11:38:30 PDT
Committed r262432: <https://trac.webkit.org/changeset/262432> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400829 [details].
Radar WebKit Bug Importer
Comment 7 2020-06-02 11:39:16 PDT
<rdar://problem/63884712>
Jason Lawrence
Comment 8 2020-06-03 09:02:52 PDT
The commit above appears to have caused a regression here: https://bugs.webkit.org/show_bug.cgi?id=212696
Jonathan Bedard
Comment 9 2020-06-03 10:32:28 PDT
Committed r262493: <https://trac.webkit.org/changeset/262493>
Jonathan Bedard
Comment 10 2020-06-03 10:33:26 PDT
(In reply to Jonathan Bedard from comment #9) > Committed r262493: <https://trac.webkit.org/changeset/262493> This is a build-fix for Debug Catalyst builds.
Note You need to log in before you can comment on or make changes to this bug.