Summary: | Allow using web processes for service workers even though they loaded about URLs | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
Component: | Service Workers | Assignee: | youenn fablet <youennf> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, cdumez, jbedard, Lawrence.j, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Local Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=212696 | ||||||||
Attachments: |
|
Description
youenn fablet
2020-05-28 06:04:41 PDT
Created attachment 400448 [details]
Patch
Test failures are related to a runtime flag change, this will be fixed at https://bugs.webkit.org/show_bug.cgi?id=212466. Comment on attachment 400448 [details]
Patch
This changes also the WebProcessCache, which might be an improvement as well.
The case that might need to be dealt with in the future is the case of a tab opening about:blank in another process and then writing data on it.
The new process should then have its registrable domain set to the tab opener and I am not sure this is guaranteed now.
Comment on attachment 400448 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400448&action=review > Source/WebKit/ChangeLog:9 > + A web process that is running service workers and is laoding an about:blank page will also kill its service workers. typo: laoding Created attachment 400829 [details]
Patch for landing
Committed r262432: <https://trac.webkit.org/changeset/262432> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400829 [details]. The commit above appears to have caused a regression here: https://bugs.webkit.org/show_bug.cgi?id=212696 Committed r262493: <https://trac.webkit.org/changeset/262493> (In reply to Jonathan Bedard from comment #9) > Committed r262493: <https://trac.webkit.org/changeset/262493> This is a build-fix for Debug Catalyst builds. |