Summary: | Add .editorconfig | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yoshiaki Jitsukawa <yoshiaki.jitsukawa> | ||||||
Component: | Tools / Tests | Assignee: | Yoshiaki Jitsukawa <yoshiaki.jitsukawa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | darin, don.olmstead, Hironori.Fujii, mark.lam, webkit-bug-importer, ysuzuki | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=212763 | ||||||||
Attachments: |
|
Description
Yoshiaki Jitsukawa
2020-05-28 05:28:04 PDT
Created attachment 400446 [details]
Patch
Created attachment 400498 [details]
Patch
Removed "root" in order to honor parent .editorconfig user may be using. Thanks for the review! Committed r262408: <https://trac.webkit.org/changeset/262408> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400498 [details]. Comment on attachment 400498 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400498&action=review > .editorconfig:8 > +trim_trailing_whitespace = true Why this? As a result of this change, it's forcing my editor (bbedit) to trim trailing whitespaces in a file every time I save. That makes for a lot of unrelated changes on every patch. Is this really necessary? (In reply to Mark Lam from comment #7) > Comment on attachment 400498 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=400498&action=review > > > .editorconfig:8 > > +trim_trailing_whitespace = true > > Why this? As a result of this change, it's forcing my editor (bbedit) to > trim trailing whitespaces in a file every time I save. That makes for a lot > of unrelated changes on every patch. Is this really necessary? Yeah, I think we should remove this line from .editorconfig. I'm working around this issue by adding let g:EditorConfig_disable_rules = ['trim_trailing_whitespace'] to my .vimrc :P |