Bug 212463

Summary: Add .editorconfig
Product: WebKit Reporter: Yoshiaki Jitsukawa <yoshiaki.jitsukawa>
Component: Tools / TestsAssignee: Yoshiaki Jitsukawa <yoshiaki.jitsukawa>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, don.olmstead, fujii.hironori, mark.lam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=212763
Attachments:
Description Flags
Patch
none
Patch none

Yoshiaki Jitsukawa
Reported 2020-05-28 05:28:04 PDT
Add .editorconfig mainly for Visual Studio.
Attachments
Patch (1.46 KB, patch)
2020-05-28 05:37 PDT, Yoshiaki Jitsukawa 		no flags
DetailsFormatted DiffDiff
Patch (1.42 KB, patch)
2020-05-28 13:05 PDT, Yoshiaki Jitsukawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yoshiaki Jitsukawa
Comment 1 2020-05-28 05:37:26 PDT
Created attachment 400446 [details] Patch
Yoshiaki Jitsukawa
Comment 2 2020-05-28 13:05:27 PDT
Created attachment 400498 [details] Patch
Yoshiaki Jitsukawa
Comment 3 2020-05-28 13:07:06 PDT
Removed "root" in order to honor parent .editorconfig user may be using.
Yoshiaki Jitsukawa
Comment 4 2020-06-02 00:42:36 PDT
Thanks for the review!
EWS
Comment 5 2020-06-02 00:44:52 PDT
Committed r262408: <https://trac.webkit.org/changeset/262408> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400498 [details].
Radar WebKit Bug Importer
Comment 6 2020-06-02 00:45:18 PDT
<rdar://problem/63863651>
Mark Lam
Comment 7 2020-06-04 07:05:58 PDT
Comment on attachment 400498 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400498&action=review > .editorconfig:8 > +trim_trailing_whitespace = true Why this? As a result of this change, it's forcing my editor (bbedit) to trim trailing whitespaces in a file every time I save. That makes for a lot of unrelated changes on every patch. Is this really necessary?
Yusuke Suzuki
Comment 8 2020-06-04 09:57:30 PDT
(In reply to Mark Lam from comment #7) > Comment on attachment 400498 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=400498&action=review > > > .editorconfig:8 > > +trim_trailing_whitespace = true > > Why this? As a result of this change, it's forcing my editor (bbedit) to > trim trailing whitespaces in a file every time I save. That makes for a lot > of unrelated changes on every patch. Is this really necessary? Yeah, I think we should remove this line from .editorconfig. I'm working around this issue by adding let g:EditorConfig_disable_rules = ['trim_trailing_whitespace'] to my .vimrc :P
Note You need to log in before you can comment on or make changes to this bug.