Summary: | [Flatpak][GStreamer] all commands, except webkit-build, fails if GST_BUILD_PATH is set | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Víctor M. Jáquez L. <vjaquez> | ||||||||
Component: | Tools / Tests | Assignee: | Víctor M. Jáquez L. <vjaquez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | clopez, pnormand, webkit-bug-importer, zan | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | All | ||||||||||
OS: | Linux | ||||||||||
Attachments: |
|
Description
Víctor M. Jáquez L.
2020-05-27 07:09:45 PDT
Created attachment 400332 [details]
Patch
Created attachment 400439 [details]
Patch
Comment on attachment 400439 [details]
Patch
Can you check if this variant works on your side?
(In reply to Philippe Normand from comment #3) > Comment on attachment 400439 [details] > Patch > > Can you check if this variant works on your side? It seems not. GST_BUILD_PATH=/home/vjaquez/gst/gst-build Tools/Scripts/build-webkit --gtk --debug --help Building flatpak based environment Building `gst-build` /home/vjaquez/gst/gst-build ninja: Entering directory `/app/webkit/WebKitBuild/gst-build ninja: no work to do. usage: gst-env [-h] [--builddir BUILDDIR] [--srcdir SRCDIR] [--sysroot SYSROOT] [--wine WINE] [--winepath WINEPATH] [--only-environment] optional arguments: -h, --help show this help message and exit --builddir BUILDDIR The meson build directory --srcdir SRCDIR The top level source directory --sysroot SYSROOT The sysroot path used during cross-compilation --wine WINE Build a wine env based on specified wine command --winepath WINEPATH Extra path to set to WINEPATH. --only-environment Do not start a shell, only print required environment. Created attachment 400444 [details]
Patch
testing the latest patch, it iterates endlessly on meson reconfiguration. Yeah here too, I had to nuke my gst-build build dir, once only though. Yep. Removing WebKitBuild/gst-build everything seems to work as expected \o/ Committed r262297: <https://trac.webkit.org/changeset/262297> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400444 [details]. |