Bug 212402

Summary: RealtimeIncomingVideoSourceCocoa::OnFrame should use video frame timestamp
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

youenn fablet
Reported 2020-05-27 01:45:15 PDT
RealtimeIncomingVideoSourceCocoa::OnFrame should use video frame timestamp
Attachments
Patch (18.55 KB, patch)
2020-05-27 02:45 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (18.54 KB, patch)
2020-05-27 04:28 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-05-27 02:45:31 PDT
Created attachment 400317 [details] Patch
youenn fablet
Comment 2 2020-05-27 04:28:39 PDT
Created attachment 400320 [details] Patch
Eric Carlson
Comment 3 2020-05-27 09:59:37 PDT
Comment on attachment 400320 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400320&action=review Nice simplification! > Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:331 > while (!m_pendingVideoSampleQueue.isEmpty()) { > - if (m_pendingVideoSampleQueue.first()->decodeTime() > now) > + auto presentationTime = m_pendingVideoSampleQueue.first()->presentationTime(); > + if (presentationTime.isValid() && presentationTime > now) > break; > m_pendingVideoSampleQueue.removeFirst(); Will this do the right thing with 'display immediately' samples?
youenn fablet
Comment 4 2020-05-27 13:30:54 PDT
(In reply to Eric Carlson from comment #3) > Comment on attachment 400320 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=400320&action=review > > Nice simplification! > > > Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:331 > > while (!m_pendingVideoSampleQueue.isEmpty()) { > > - if (m_pendingVideoSampleQueue.first()->decodeTime() > now) > > + auto presentationTime = m_pendingVideoSampleQueue.first()->presentationTime(); > > + if (presentationTime.isValid() && presentationTime > now) > > break; > > m_pendingVideoSampleQueue.removeFirst(); > > Will this do the right thing with 'display immediately' samples? There might indeed be an issue in general. In practice, for WebRTC usage (which is the sole use of this class), we could probably further simplify and just use one sample as a buffer instead of a duque, since we want to use the newest sample for WebRTC.
EWS
Comment 5 2020-05-28 01:40:46 PDT
Committed r262238: <https://trac.webkit.org/changeset/262238> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400320 [details].
Radar WebKit Bug Importer
Comment 6 2020-05-28 01:41:18 PDT
<rdar://problem/63710172>
Note You need to log in before you can comment on or make changes to this bug.