Bug 212389

Summary: Sort PlatformEnableCocoa.h and add definitions for the simple cases from FeatureDefines.xcconfig
Product: WebKit Reporter: Darin Adler <darin>
Component: WebKit Misc.Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, cdumez, cmarcelo, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+, darin: commit-queue+

Darin Adler
Reported 2020-05-26 15:30:46 PDT
Sort PlatformEnableCocoa.h and add definitions for the simple cases from FeatureDefines.xcconfig
Attachments
Patch (20.95 KB, patch)
2020-05-26 16:36 PDT, Darin Adler 		andersca: review+
darin: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2020-05-26 16:36:49 PDT
Created attachment 400287 [details] Patch
Anders Carlsson
Comment 2 2020-05-26 21:25:09 PDT
Comment on attachment 400287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400287&action=review > Source/WTF/wtf/PlatformEnableCocoa.h:39 > +/* Please keep the following in alphabetical order so we can notice duplicates. */ Why not use // C++ style comments?
Darin Adler
Comment 3 2020-05-27 10:20:39 PDT
Comment on attachment 400287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400287&action=review >> Source/WTF/wtf/PlatformEnableCocoa.h:39 >> +/* Please keep the following in alphabetical order so we can notice duplicates. */ > > Why not use // C++ style comments? I don’t know. I know these headers are very widely included, even in non-C++ files. But I don’t know if we have to support any language/compiler configuration that does not support them.
Darin Adler
Comment 4 2020-05-27 10:22:37 PDT
Committed r262199: <https://trac.webkit.org/changeset/262199>
Radar WebKit Bug Importer
Comment 5 2020-05-27 10:23:16 PDT
<rdar://problem/63679872>
Note You need to log in before you can comment on or make changes to this bug.