Bug 212378

Summary: IteratorClose should suppress GetMethod errors
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: JavaScriptCoreAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Minor CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
URL: https://github.com/tc39/ecma262/pull/1408
Attachments:
Description Flags
Patch keith_miller: review+

Description Alexey Shvayka 2020-05-26 09:14:56 PDT 
IteratorClose should suppress GetMethod errors
Comment 1 Alexey Shvayka 2020-05-26 09:17:57 PDT 
Created attachment 400252 [details]
Patch
Comment 2 Keith Miller 2020-05-26 14:43:09 PDT 
Comment on attachment 400252 [details]
Patch

r=me.

RE, Your offline question about whether emitIteratorGenericClose should take the label. I don't think it's too important either way and I could imagine other places where you don't want the label. I'd leave it as is.
Comment 3 Alexey Shvayka 2020-05-26 15:16:14 PDT 
Committed r262165: <https://trac.webkit.org/changeset/262165>
Comment 4 Radar WebKit Bug Importer 2020-05-26 15:17:13 PDT 
<rdar://problem/63644865>
Comment 5 Alexey Shvayka 2020-05-26 15:18:49 PDT 
(In reply to Keith Miller from comment #2)
> RE, Your offline question about whether emitIteratorGenericClose should take
> the label. I don't think it's too important either way and I could imagine
> other places where you don't want the label. I'd leave it as is.

Thank you, Keith!