Bug 212374

Summary: [css-grid] Import tests for the grid as flexbox item case
Product: WebKit Reporter: Javier Fernandez <jfernandez>
Component: Tools / TestsAssignee: Javier Fernandez <jfernandez>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, Lawrence.j, obrufau, rego, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=209282
https://bugs.webkit.org/show_bug.cgi?id=212525
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Javier Fernandez
Reported 2020-05-26 06:57:37 PDT
Import tests from the WPT repository to cover the changes required to fix bug #209282
Attachments
Patch (24.75 KB, patch)
2020-05-26 07:28 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Patch (24.94 KB, patch)
2020-05-27 07:37 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Patch (31.54 KB, patch)
2020-05-28 15:02 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Javier Fernandez
Comment 1 2020-05-26 07:28:17 PDT
Created attachment 400243 [details] Patch
Javier Fernandez
Comment 2 2020-05-27 07:37:20 PDT
Created attachment 400336 [details] Patch
Javier Fernandez
Comment 3 2020-05-27 07:39:51 PDT
These tests were already reviewed and merged upstream [1] so we can land this patch now. [1] https://github.com/web-platform-tests/wpt/pull/23769
Manuel Rego Casasnovas
Comment 4 2020-05-27 07:56:55 PDT
Comment on attachment 400336 [details] Patch r+
Javier Fernandez
Comment 5 2020-05-28 15:02:44 PDT
Created attachment 400511 [details] Patch
EWS
Comment 6 2020-05-29 01:00:48 PDT
Committed r262284: <https://trac.webkit.org/changeset/262284> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400511 [details].
Radar WebKit Bug Importer
Comment 7 2020-05-29 01:01:20 PDT
<rdar://problem/63750801>
Truitt Savell
Comment 8 2020-05-29 08:07:58 PDT
This import introduced 4 new test failures for Mac: imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-001.html imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-003.html imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-007.html imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-008.html History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-grid%2Flayout-algorithm%2Fgrid-as-flex-item-should-not-shrink-to-fit-001.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-grid%2Flayout-algorithm%2Fgrid-as-flex-item-should-not-shrink-to-fit-003.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-grid%2Flayout-algorithm%2Fgrid-as-flex-item-should-not-shrink-to-fit-007.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-grid%2Flayout-algorithm%2Fgrid-as-flex-item-should-not-shrink-to-fit-008.html Results: https://build.webkit.org/results/Apple-Catalina-Release-WK2-Tests/r262292%20(5933)/results.html The image diff shows a red square for each of these tests.
Jason Lawrence
Comment 9 2020-05-29 08:12:12 PDT
The failures are being tracked here: https://bugs.webkit.org/show_bug.cgi?id=212525
Truitt Savell
Comment 10 2020-05-29 11:13:05 PDT
It looks like you marked these as Failure when they should be ImageOnlyFailure
Truitt Savell
Comment 11 2020-05-29 11:15:42 PDT
Fixed the expectations here: https://trac.webkit.org/changeset/262305/webkit
Javier Fernandez
Comment 12 2020-05-29 13:30:36 PDT
(In reply to Truitt Savell from comment #11) > Fixed the expectations here: https://trac.webkit.org/changeset/262305/webkit Sorry about than and thanks for the fix.
Note You need to log in before you can comment on or make changes to this bug.