Bug 212337

Summary: Extended Color Cleanup: Use the name SimpleColor consistently
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cdumez, changseok, darin, dino, esprehn+autocc, ews-watchlist, fred.wang, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard, mifenton, mmaxfield, pdr, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
Patch
none
Patch
none
Patch
none
Patch andersca: review+

Sam Weinig
Reported 2020-05-24 13:41:58 PDT
Extended Color Cleanup: Use the name SimpleColor consistently
Attachments
WIP (69.81 KB, patch)
2020-05-24 13:49 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (71.02 KB, patch)
2020-05-24 14:17 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (85.01 KB, patch)
2020-05-24 14:29 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (85.19 KB, patch)
2020-05-24 16:46 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (86.02 KB, patch)
2020-05-24 18:14 PDT, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-05-24 13:49:31 PDT Comment hidden (obsolete)
Sam Weinig
Comment 2 2020-05-24 14:17:21 PDT Comment hidden (obsolete)
Sam Weinig
Comment 3 2020-05-24 14:29:38 PDT Comment hidden (obsolete)
Sam Weinig
Comment 4 2020-05-24 16:46:09 PDT Comment hidden (obsolete)
Sam Weinig
Comment 5 2020-05-24 18:14:44 PDT
Created attachment 400184 [details] Patch
Anders Carlsson
Comment 6 2020-05-25 08:49:00 PDT
Comment on attachment 400184 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400184&action=review > Source/WebCore/ChangeLog:12 > + the type it returns. Also took the opertunity to make it return "opertunity" > Source/WebCore/ChangeLog:15 > + It made not real sense to keep it in Color.h "It made not" > Source/WebCore/css/parser/CSSParserFastPaths.cpp:423 > + auto color = SimpleColor::parseHexColor(characters, length); Can write this as if (auto color = ...) return color;
Sam Weinig
Comment 7 2020-05-25 11:30:18 PDT
Committed r262128: <https://trac.webkit.org/changeset/262128>
Radar WebKit Bug Importer
Comment 8 2020-05-25 11:31:16 PDT
<rdar://problem/63602543>
Note You need to log in before you can comment on or make changes to this bug.