Bug 212337 - Extended Color Cleanup: Use the name SimpleColor consistently
Summary: Extended Color Cleanup: Use the name SimpleColor consistently
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-24 13:41 PDT by Sam Weinig
Modified: 2020-05-25 11:31 PDT (History)
18 users (show)

See Also:

Attachments
WIP (69.81 KB, patch)
2020-05-24 13:49 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (71.02 KB, patch)
2020-05-24 14:17 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (85.01 KB, patch)
2020-05-24 14:29 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (85.19 KB, patch)
2020-05-24 16:46 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (86.02 KB, patch)
2020-05-24 18:14 PDT, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-05-24 13:41:58 PDT 
Extended Color Cleanup: Use the name SimpleColor consistently
Comment 1 Sam Weinig 2020-05-24 13:49:31 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2020-05-24 14:17:21 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2020-05-24 14:29:38 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2020-05-24 16:46:09 PDT Comment hidden (obsolete)
Comment 5 Sam Weinig 2020-05-24 18:14:44 PDT 
Created attachment 400184 [details]
Patch
Comment 6 Anders Carlsson 2020-05-25 08:49:00 PDT 
Comment on attachment 400184 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400184&action=review

> Source/WebCore/ChangeLog:12
> +          the type it returns. Also took the opertunity to make it return

"opertunity"

> Source/WebCore/ChangeLog:15
> +          It made not real sense to keep it in Color.h

"It made not"

> Source/WebCore/css/parser/CSSParserFastPaths.cpp:423
> +        auto color = SimpleColor::parseHexColor(characters, length);

Can write this as

if (auto color = ...)
    return color;
Comment 7 Sam Weinig 2020-05-25 11:30:18 PDT 
Committed r262128: <https://trac.webkit.org/changeset/262128>
Comment 8 Radar WebKit Bug Importer 2020-05-25 11:31:16 PDT 
<rdar://problem/63602543>