Bug 212321

Summary: [GTK4] Make inspector work
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, berto, bugs-noreply, ews-watchlist, gustavo
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 210100    
Attachments:
Description Flags
Patch aperez: review+

Carlos Garcia Campos
Reported 2020-05-24 05:48:53 PDT
And remote inspector as well.
Attachments
Patch (11.72 KB, patch)
2020-05-30 05:27 PDT, Carlos Garcia Campos 		aperez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2020-05-30 05:27:28 PDT
Created attachment 400664 [details] Patch
EWS Watchlist
Comment 2 2020-05-30 05:28:30 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Adrian Perez
Comment 3 2020-06-01 01:57:56 PDT
Comment on attachment 400664 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400664&action=review > Source/WebKit/ChangeLog:11 > + (webkitWebViewBaseDispose): Use specific functions to remve the children. Typo: remve → remove.
Carlos Garcia Campos
Comment 4 2020-06-01 02:24:12 PDT
Committed r262371: <https://trac.webkit.org/changeset/262371>
Note You need to log in before you can comment on or make changes to this bug.