Bug 212276

Summary:

[IPC] Add support for specifying `Async WantsConnection` in message files

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

WebKit2

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, aestes, cdumez, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=228168

Attachments:

Description	Flags
Patch	none

Description Wenson Hsieh 2020-05-22 13:36:13 PDT

Example:

    Foo(...) -> (...) Async WantsConnection

...results in this generated code:

    IPC::handleMessageAsync<Messages::WebPageProxy::Foo>(connection, connection, decoder, this, &WebPageProxy::foo);

...which results in a compiler error due to the duplicated `connection` argument.

Comment 1 Wenson Hsieh 2020-05-22 14:04:17 PDT

Created attachment 400074 [details]
Patch

Comment 2 EWS 2020-05-22 14:45:51 PDT

Committed r262075: <https://trac.webkit.org/changeset/262075>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400074 [details].

Comment 3 Radar WebKit Bug Importer 2020-05-22 14:46:14 PDT

<rdar://problem/63554831>