Bug 212265

Summary: Extended Color Cleanup: Make alpha premultiplication code more consistent and clear regarding what works with extended colors
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, luiz, macpherson, menard, noam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 212184    
Attachments:
Description Flags
Patch
none
Patch none

Description Sam Weinig 2020-05-22 10:10:06 PDT
Extended Color Cleanup: Make alpha premultiplication code more consistent and clear regarding what works with extended colors
Comment 1 Sam Weinig 2020-05-22 10:36:14 PDT
Created attachment 400055 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-05-22 12:08:30 PDT
Comment on attachment 400055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400055&action=review

> Source/WebCore/platform/graphics/ColorUtilities.h:194
> +WEBCORE_EXPORT FloatComponents premultiplyAlpha(const FloatComponents& sRGBCompontents);

Maybe just premultiplied()? "premultiply" sounds like it's in-place, and the "alpha" is a given.
Comment 3 Sam Weinig 2020-05-22 12:39:57 PDT
Created attachment 400065 [details]
Patch
Comment 4 EWS 2020-05-22 13:16:25 PDT
Committed r262070: <https://trac.webkit.org/changeset/262070>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400065 [details].
Comment 5 Radar WebKit Bug Importer 2020-05-22 13:17:15 PDT
<rdar://problem/63551635>