Bug 212264

Summary: [css-flex] Allow indefinite size flex items to be definite wrt resolving percentages inside them
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alex.wayfer, changseok, clopez, ddkilzer, esprehn+autocc, ews-watchlist, glenn, gsnedders, kondapallykalyan, oliverjash, pdr, rego, simon.fraser, svillar, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar, WPTImpact
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=213110
https://bugs.webkit.org/show_bug.cgi?id=214655
Bug Depends on: 210089    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch rego: review+

Sergio Villar Senin
Reported 2020-05-22 08:35:07 PDT
[css-flex] Allow indefinite size flex items to be definite wrt resolving percentages inside them
Attachments
Patch (7.61 KB, patch)
2020-05-22 08:43 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Patch (7.61 KB, patch)
2020-05-22 08:44 PDT, Sergio Villar Senin 		rego: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2020-05-22 08:43:12 PDT
Created attachment 400049 [details] Patch
Sergio Villar Senin
Comment 2 2020-05-22 08:44:37 PDT
Created attachment 400050 [details] Patch
Manuel Rego Casasnovas
Comment 3 2020-05-22 09:34:11 PDT
Comment on attachment 400050 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400050&action=review r=me, thanks for the patch. > LayoutTests/css3/flexbox/definite-main-size.html:61 > <div class="rect flex-none"></div> Would be nice to move this test "definite-main-size.html" into WPT. It seems it doesn't have anything engine related. Of course this could be done in a follow-up patch.
Sergio Villar Senin
Comment 4 2020-05-25 07:18:32 PDT
Committed r262124: <https://trac.webkit.org/changeset/262124>
Radar WebKit Bug Importer
Comment 5 2020-05-25 07:19:17 PDT
<rdar://problem/63597024>
Simon Fraser (smfr)
Comment 6 2020-06-11 20:29:40 PDT
This caused bug 213110.
Sergio Villar Senin
Comment 7 2020-06-14 22:57:02 PDT
Reverted r262124 for reason: Twitter videos go blank after exiting fullscreen Committed r263018: <https://trac.webkit.org/changeset/263018>
Sergio Villar Senin
Comment 8 2020-06-23 08:56:25 PDT
Committed r263399: <https://trac.webkit.org/changeset/263399>
alan
Comment 9 2020-07-22 14:29:07 PDT
This seems to have regressed Youtube's video uploading page (see bug 214655)
Manuel Rego Casasnovas
Comment 10 2020-07-23 00:44:05 PDT
(In reply to zalan from comment #9) > This seems to have regressed Youtube's video uploading page (see bug 214655) Sergio is on holidays until the end of the month, it might be better to revert it until he has time to investigate the regression properly.
alan
Comment 11 2020-07-23 05:10:45 PDT
(In reply to Manuel Rego Casasnovas from comment #10) > (In reply to zalan from comment #9) > > This seems to have regressed Youtube's video uploading page (see bug 214655) > > Sergio is on holidays until the end of the month, it might be better to > revert it until he has time to investigate the regression properly. Ok, thanks! Will revert it for now.
alan
Comment 12 2020-07-23 10:29:22 PDT
reverted in https://trac.webkit.org/changeset/264775/webkit
David Kilzer (:ddkilzer)
Comment 13 2020-07-23 10:40:40 PDT
(In reply to zalan from comment #12) > reverted in https://trac.webkit.org/changeset/264775/webkit
Sam Sneddon [:gsnedders]
Comment 14 2020-08-25 20:55:20 PDT
*** Bug 210477 has been marked as a duplicate of this bug. ***
Sergio Villar Senin
Comment 15 2020-09-07 02:54:21 PDT
Committed r266696: <https://trac.webkit.org/changeset/266696>
Joonghun Park
Comment 16 2021-10-24 06:34:26 PDT
*** Bug 198375 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.