Bug 21225
| Summary: | Machine::retrieveLastCaller should check for a NULL codeBlock | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Geoffrey Garen <ggaren> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | kmccullough |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.5 | ||
Geoffrey Garen
Machine::retrieveLastCaller reads a CodeBlock out of the register file without checking for NULL. Since CodeBlocks in the register file can be NULL, it should check.
I thought you could crash this code through something like "console.log.call(console, 'hello world')", but that doesn't quite do it. Still, we should just be safe and check for NULL.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Geoffrey Garen
Committed revision 37087.