Bug 212245

Summary: DataTransfer.files contains multiple files when pasting a single image with multiple representations
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, jessicap, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
Patch for landing none

Wenson Hsieh
Reported 2020-05-21 18:51:20 PDT
<rdar://problem/60240436>
Attachments
Patch (13.15 KB, patch)
2020-05-21 19:15 PDT, Wenson Hsieh 		thorton: review+
DetailsFormatted DiffDiff
Patch for landing (13.15 KB, patch)
2020-05-21 21:05 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2020-05-21 19:15:16 PDT
Created attachment 400010 [details] Patch
Tim Horton
Comment 2 2020-05-21 21:02:43 PDT
Comment on attachment 400010 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400010&action=review > Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.mm:246 > - _writtenPasteboardItems = adoptNS([[NSMutableArray<NSPasteboardItem *> alloc] initWithCapacity:objects.count]); > + auto items = adoptNS([[NSMutableArray<NSPasteboardItem *> alloc] initWithCapacity:objects.count]); It looks funny to see the type specialization there! But I guess it is fine. > Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:58 > + for (NSDictionary <NSString *, NSData *> *typesAndData in items) { No space before the < ... I /think/?
Wenson Hsieh
Comment 3 2020-05-21 21:04:38 PDT
Comment on attachment 400010 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400010&action=review >> Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.mm:246 >> + auto items = adoptNS([[NSMutableArray<NSPasteboardItem *> alloc] initWithCapacity:objects.count]); > > It looks funny to see the type specialization there! But I guess it is fine. 😎 >> Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:58 >> + for (NSDictionary <NSString *, NSData *> *typesAndData in items) { > > No space before the < ... I /think/? Ah, that’s right — it’s only a space before the < if it’s for a @protocol, IIRC.
Wenson Hsieh
Comment 4 2020-05-21 21:05:47 PDT
Created attachment 400023 [details] Patch for landing
EWS
Comment 5 2020-05-21 21:42:52 PDT
Committed r262047: <https://trac.webkit.org/changeset/262047> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400023 [details].
Wenson Hsieh
Comment 6 2020-08-04 20:45:26 PDT
*** Bug 215145 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.