Bug 212243

Summary: iOS: Pressing tab in the Mail subject field moves focus to the body, but pressing shift tab doesn't move it back
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: megan_gardner, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tim Horton
Reported 2020-05-21 17:28:33 PDT
iOS: Pressing tab in the Mail subject field moves focus to the body, but pressing shift tab doesn't move it back
Attachments
Patch (9.67 KB, patch)
2020-05-21 17:31 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (9.72 KB, patch)
2020-05-22 03:43 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2020-05-21 17:31:58 PDT
Created attachment 400004 [details] Patch
Tim Horton
Comment 2 2020-05-21 17:32:00 PDT
<rdar://problem/59127764>
Tim Horton
Comment 3 2020-05-21 18:22:36 PDT
*** Bug 212242 has been marked as a duplicate of this bug. ***
Wenson Hsieh
Comment 4 2020-05-21 23:06:29 PDT
Comment on attachment 400004 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400004&action=review > Source/WebCore/page/FocusController.cpp:453 > + Document* document = focusedOrMainFrame().document(); I think we generally prefer the strong ref here, as it’s not clear that the code below won’t nuke document. > Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:847 > + TestWebKitAPI::Util::run(&delegate.get()->_done); Nit - I don’t think you need the .get() here. > Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:862 > + TestWebKitAPI::Util::run(&delegate.get()->_done); Ditto. > Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:876 > + TestWebKitAPI::Util::run(&delegate.get()->_didSendKeyEvent); Ditto. > Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:878 > + ASSERT_FALSE(delegate.get()->_done); Ditto.
Tim Horton
Comment 5 2020-05-22 03:43:43 PDT
Created attachment 400035 [details] Patch
EWS
Comment 6 2020-05-22 04:15:04 PDT
Committed r262051: <https://trac.webkit.org/changeset/262051> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400035 [details].
Note You need to log in before you can comment on or make changes to this bug.