| Summary: | Fix some thread safety issues with ScrollController timers | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | cmarcelo, ews-watchlist, fred.wang, jamesr, luiz, simon.fraser, tonikitoo, webkit-bug-importer, wenson_hsieh | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Simon Fraser (smfr)
2020-05-21 16:10:55 PDT
Created attachment 399995 [details]
Patch
Comment on attachment 399995 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399995&action=review > Source/WebCore/ChangeLog:14 > + timers would grap the main thread runloop. Fix by creating the timers on demand. “grap” > Source/WebCore/page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.h:56 > + void wasBeRemovedFromTree() final; “wasBe" > Source/WebCore/platform/Logging.cpp:93 > + LogScrolling.state = WTFLogChannelState::On; I don’t think you meant to add this. Created attachment 399998 [details]
Patch
Created attachment 399999 [details]
Patch
Created attachment 400001 [details]
Patch
Comment on attachment 400001 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400001&action=review > Source/WebCore/ChangeLog:49 > + * platform/Logging.cpp: > + (WebCore::initializeLogChannelsIfNecessary): Nit - you can remove this. |