Bug 21220

Summary:

Show the node highlight all the time when hovering

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector (Deprecated)

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aroben, kmccullough, timothy

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed patch	kmccullough: review+

Timothy Hatcher

Reported 2008-09-29 13:30:52 PDT

We should show the node highlight all the time when hovering in the DOM tree.

Attachments
Proposed patch (23.56 KB, patch) 2008-09-29 13:37 PDT, Timothy Hatcher	kmccullough: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Timothy Hatcher

Comment 1 2008-09-29 13:37:12 PDT

Created attachment 23919 [details] Proposed patch

Adam Roben (:aroben)

Comment 2 2008-09-29 14:01:21 PDT

Didn't we intentionally revert this behavior a while back?

Timothy Hatcher

Comment 3 2008-09-29 14:03:42 PDT

Yes, but that was when we scrolled to reveal the node. Now that we don't do this, the highlight is not annoying to use and better matches Firebug. Our current behavior is confusing developers too. <rdar://problem/6118902>

Timothy Hatcher

Comment 4 2008-09-29 14:08:11 PDT

Also this patch requires hovering a node for 500ms before the highlight shows. (The previous attempt highlighted the instant you hovered.) This new behavior makes it less twitchy and behaves like a tooltip (hover to get it, then hover to the next element hows the highlight faster). Plus the feedback about the previous implementation said there was no feedback in the inspector. We now have a hover effect in the inspector too so you see the row for the node you are over. So there is a tie between the two.

Kevin McCullough

Comment 5 2008-09-29 15:26:34 PDT

Comment on attachment 23919 [details] Proposed patch change "sooner if there if one is already showing" to "sooner if there is one already showing" could move the setting of element on line 180 to 195 in ElementsTreeOutline.prototype

Timothy Hatcher

Comment 6 2008-09-29 15:34:41 PDT

Landed in r37079.

Note You need to log in before you can comment on or make changes to this bug.