Bug 212187

Summary: [css-grid] Update WPT imported tests and deduplicate common tests
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: CSSAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: jfernandez, obrufau, rego, svillar, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Carlos Alberto Lopez Perez
Reported 2020-05-20 22:10:53 PDT
Like we did for flexbox in bug 191460 let's update the WPT import of css-grid tests and deduplicate old layout tests in favor of WPT ones.
Attachments
Patch (3.54 MB, patch)
2020-05-20 22:23 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Patch (3.54 MB, patch)
2020-05-21 10:28 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Patch (3.54 MB, patch)
2020-05-21 13:23 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Patch (3.54 MB, patch)
2020-05-21 23:31 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2020-05-20 22:23:56 PDT
Created attachment 399933 [details] Patch test EWS, ignore
Carlos Alberto Lopez Perez
Comment 2 2020-05-21 10:28:07 PDT
Created attachment 399964 [details] Patch test EWS, ignore
Carlos Alberto Lopez Perez
Comment 3 2020-05-21 13:23:38 PDT
Created attachment 399977 [details] Patch test EWS, ignore.
Carlos Alberto Lopez Perez
Comment 4 2020-05-21 23:31:45 PDT
Created attachment 400031 [details] Patch
Carlos Alberto Lopez Perez
Comment 5 2020-05-22 06:41:16 PDT
Comment on attachment 400031 [details] Patch r? Asking for review now. All EWS green.
EWS
Comment 6 2020-05-22 07:13:04 PDT
Committed r262056: <https://trac.webkit.org/changeset/262056> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400031 [details].
Radar WebKit Bug Importer
Comment 7 2020-05-22 07:14:18 PDT
<rdar://problem/63539293>
Note You need to log in before you can comment on or make changes to this bug.