Bug 212178

Summary: Add an option that exposes functions on the global object to turn on and off the sampling profiler and the super sampler
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ross.kirsling, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
ysuzuki: review+
patch for landing none

Description Saam Barati 2020-05-20 16:49:08 PDT 
These are helpful to have them only enable in a certain range of code. For example, when profiling Speedometer, it's useful to have them only on when running actual benchmark code. This allows you to fiddle with the UI without worry that those actions are being measured and accounted for.
Comment 1 Saam Barati 2020-05-20 18:28:19 PDT 
Created attachment 399922 [details]
patch
Comment 2 Yusuke Suzuki 2020-05-20 18:31:25 PDT 
Comment on attachment 399922 [details]
patch

r=me
Comment 3 Mark Lam 2020-05-20 19:11:50 PDT 
The 32-bit build failure is real.  Can you fix?
Comment 4 Saam Barati 2020-05-20 19:49:18 PDT 
(In reply to Mark Lam from comment #3)
> The 32-bit build failure is real.  Can you fix?

Will do before landing. Just needs an ENABLE(SAMPLING_PROFILER)
Comment 5 Saam Barati 2020-05-20 22:04:01 PDT 
Created attachment 399932 [details]
patch for landing
Comment 6 EWS 2020-05-21 10:44:17 PDT 
Committed r262014: <https://trac.webkit.org/changeset/262014>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399932 [details].
Comment 7 Radar WebKit Bug Importer 2020-05-21 10:45:18 PDT 
<rdar://problem/63500143>