Bug 212142

Summary: Fix for accessibility-node-memory-management.html in isolated tree mode.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Andres Gonzalez 2020-05-20 08:46:24 PDT
Fix for accessibility-node-memory-management.html in isolated tree mode.
Comment 1 Andres Gonzalez 2020-05-20 08:57:23 PDT
Created attachment 399842 [details]
Patch
Comment 2 chris fleizach 2020-05-20 09:12:50 PDT
Comment on attachment 399842 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399842&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:380
>          auto& wrapper = item.m_wrapper ? item.m_wrapper : item.m_isolatedObject->wrapper();

is this a pointer? should we be using auto& ?
Comment 3 Andres Gonzalez 2020-05-20 10:55:09 PDT
(In reply to chris fleizach from comment #2)
> Comment on attachment 399842 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=399842&action=review
> 
> > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:380
> >          auto& wrapper = item.m_wrapper ? item.m_wrapper : item.m_isolatedObject->wrapper();
> 
> is this a pointer? should we be using auto& ?

I believe it is ok because wrapper is a reference to either NodeChange::m_wrapper or AXCoreObject::m_wrapper, which is a RetainPtr.
Comment 4 EWS 2020-05-20 11:21:14 PDT
Committed r261934: <https://trac.webkit.org/changeset/261934>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399842 [details].
Comment 5 Radar WebKit Bug Importer 2020-05-20 11:22:15 PDT
<rdar://problem/63455951>