Summary: | Fix for accessibility-node-memory-management.html in isolated tree mode. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andres Gonzalez <andresg_22> | ||||
Component: | New Bugs | Assignee: | Andres Gonzalez <andresg_22> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Andres Gonzalez
2020-05-20 08:46:24 PDT
Created attachment 399842 [details]
Patch
Comment on attachment 399842 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399842&action=review > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:380 > auto& wrapper = item.m_wrapper ? item.m_wrapper : item.m_isolatedObject->wrapper(); is this a pointer? should we be using auto& ? (In reply to chris fleizach from comment #2) > Comment on attachment 399842 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=399842&action=review > > > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:380 > > auto& wrapper = item.m_wrapper ? item.m_wrapper : item.m_isolatedObject->wrapper(); > > is this a pointer? should we be using auto& ? I believe it is ok because wrapper is a reference to either NodeChange::m_wrapper or AXCoreObject::m_wrapper, which is a RetainPtr. Committed r261934: <https://trac.webkit.org/changeset/261934> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399842 [details]. |