Bug 212140

Summary: Disable support for BeforeLoadEvent
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: 10664, achristensen, benjamin, bfulgham, calvaris, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, jer.noble, kangil.han, koivisto, kondapallykalyan, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.chromium.org/p/chromium/issues/detail?id=333318
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2020-05-20 08:32:39 PDT
Disable support for BeforeLoadEvent. Other browsers do not support it and Chrome dropped it shortly after the fork: https://bugs.chromium.org/p/chromium/issues/detail?id=333318 This is a synchronous event and therefore a frequent source of security bugs.
Attachments
Patch (7.90 KB, patch)
2020-05-20 08:47 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (127.56 KB, patch)
2020-05-20 09:40 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (156.07 KB, patch)
2020-05-20 10:45 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (156.02 KB, patch)
2020-05-20 10:52 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (156.03 KB, patch)
2020-05-20 10:54 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (147.92 KB, patch)
2020-05-20 11:05 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (147.89 KB, patch)
2020-05-20 11:20 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (156.05 KB, patch)
2020-05-20 11:26 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (155.96 KB, patch)
2020-05-20 11:50 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-05-20 08:32:56 PDT
<rdar://problem/62847577>
Chris Dumez
Comment 2 2020-05-20 08:47:00 PDT
Created attachment 399841 [details] Patch
Chris Dumez
Comment 3 2020-05-20 09:40:01 PDT
Created attachment 399846 [details] Patch
Chris Dumez
Comment 4 2020-05-20 10:45:28 PDT
Created attachment 399852 [details] Patch
Chris Dumez
Comment 5 2020-05-20 10:52:00 PDT
Created attachment 399854 [details] Patch
Chris Dumez
Comment 6 2020-05-20 10:54:56 PDT
Created attachment 399855 [details] Patch
Chris Dumez
Comment 7 2020-05-20 11:01:23 PDT
Trying to figure out why the bots won't apply my patch anymore... even though I rebased it 3 times already.
Chris Dumez
Comment 8 2020-05-20 11:05:32 PDT
Created attachment 399857 [details] Patch
Chris Dumez
Comment 9 2020-05-20 11:11:48 PDT
The issue seems to be that I am removing LayoutTests/http/tests/cache/cancel-during-revalidation-succeeded.html and this test has weird end of line characters. Not sure how to make bugzilla like my patch yet...
Chris Dumez
Comment 10 2020-05-20 11:20:44 PDT
Created attachment 399859 [details] Patch
Chris Dumez
Comment 11 2020-05-20 11:26:41 PDT
Created attachment 399860 [details] Patch
Chris Dumez
Comment 12 2020-05-20 11:50:47 PDT
Created attachment 399865 [details] Patch
EWS
Comment 13 2020-05-20 13:14:28 PDT
Committed r261946: <https://trac.webkit.org/changeset/261946> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399865 [details].
Ryan Haddad
Comment 14 2020-05-20 16:39:00 PDT
(In reply to EWS from comment #13) > Committed r261946: <https://trac.webkit.org/changeset/261946> As win-ews noted, this caused two test failures for Windows. Fixed them with rebaselines in r261971.
Chris Dumez
Comment 15 2020-05-20 16:39:24 PDT
(In reply to Ryan Haddad from comment #14) > (In reply to EWS from comment #13) > > Committed r261946: <https://trac.webkit.org/changeset/261946> > As win-ews noted, this caused two test failures for Windows. > > Fixed them with rebaselines in r261971. Thank you Ryan.
routerpipe
Comment 16 2021-11-20 23:49:43 PST
Many addons use this event beforeload to block advert , can we recovery this feature
Note You need to log in before you can comment on or make changes to this bug.