Summary: | Disable support for BeforeLoadEvent | ||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||||||||||
Component: | DOM | Assignee: | Chris Dumez <cdumez> | ||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||
Severity: | Normal | CC: | 10664, achristensen, benjamin, bfulgham, calvaris, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, jer.noble, kangil.han, koivisto, kondapallykalyan, philipj, sergio, webkit-bug-importer, youennf | ||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||
See Also: | https://bugs.chromium.org/p/chromium/issues/detail?id=333318 | ||||||||||||||||||||||
Attachments: |
|
Description
Chris Dumez
2020-05-20 08:32:39 PDT
Created attachment 399841 [details]
Patch
Created attachment 399846 [details]
Patch
Created attachment 399852 [details]
Patch
Created attachment 399854 [details]
Patch
Created attachment 399855 [details]
Patch
Trying to figure out why the bots won't apply my patch anymore... even though I rebased it 3 times already. Created attachment 399857 [details]
Patch
The issue seems to be that I am removing LayoutTests/http/tests/cache/cancel-during-revalidation-succeeded.html and this test has weird end of line characters. Not sure how to make bugzilla like my patch yet... Created attachment 399859 [details]
Patch
Created attachment 399860 [details]
Patch
Created attachment 399865 [details]
Patch
Committed r261946: <https://trac.webkit.org/changeset/261946> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399865 [details]. (In reply to EWS from comment #13) > Committed r261946: <https://trac.webkit.org/changeset/261946> As win-ews noted, this caused two test failures for Windows. Fixed them with rebaselines in r261971. (In reply to Ryan Haddad from comment #14) > (In reply to EWS from comment #13) > > Committed r261946: <https://trac.webkit.org/changeset/261946> > As win-ews noted, this caused two test failures for Windows. > > Fixed them with rebaselines in r261971. Thank you Ryan. Many addons use this event beforeload to block advert , can we recovery this feature |