Bug 212121

Summary: REGRESSION(r260978): Web Inspector: Styles: Pressing Space no longer toggles selected properties
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 211118    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
[Video] With patch applied none

Nikita Vasilyev
Reported 2020-05-19 20:43:01 PDT
Steps: 1. Inspect <body> on this page 2. Select several CSS properties (click and hold on the 1st body's property, drag down) 3. Press Space Expected: Selected properties are commented out now. Actual: Nothing. Notes: I broke it by removing `tabIndex=-1` :( https://trac.webkit.org/changeset/260978/webkit#file3
Attachments
Patch (2.93 KB, patch)
2020-05-19 20:58 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Video] With patch applied (1.69 MB, video/quicktime)
2020-05-19 20:59 PDT, Nikita Vasilyev 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2020-05-19 20:58:58 PDT
Created attachment 399804 [details] Patch
Nikita Vasilyev
Comment 2 2020-05-19 20:59:49 PDT
Created attachment 399805 [details] [Video] With patch applied
Radar WebKit Bug Importer
Comment 3 2020-05-19 21:00:13 PDT
<rdar://problem/63429559>
Devin Rousso
Comment 4 2020-05-20 10:37:49 PDT
Comment on attachment 399804 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399804&action=review rs=me > Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:98 > + let propertyView = new WI.SpreadsheetStyleProperty(this, property, {selectable: true}); and this is why I love `options = {}` 😁
EWS
Comment 5 2020-05-20 11:01:55 PDT
Committed r261933: <https://trac.webkit.org/changeset/261933> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399804 [details].
Note You need to log in before you can comment on or make changes to this bug.