Bug 212107

Summary: WTF::LockedPrintStream should be final
Product: WebKit Reporter: Adrian Perez <aperez>
Component: Web Template FrameworkAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Adrian Perez
Reported 2020-05-19 13:56:06 PDT
As Clang wisely advises: ../Source/WTF/wtf/LockedPrintStream.h:38:26: warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class] ~LockedPrintStream() final; ^ ../Source/WTF/wtf/LockedPrintStream.h:35:7: note: mark 'WTF::LockedPrintStream' as 'final' to silence this warning class LockedPrintStream : public PrintStream { ^ 1 warning generated.
Attachments
Patch (1.17 KB, patch)
2020-05-19 13:57 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2020-05-19 13:57:29 PDT
Created attachment 399767 [details] Patch
Darin Adler
Comment 2 2020-05-19 14:00:10 PDT
Comment on attachment 399767 [details] Patch OK, why not.
EWS
Comment 3 2020-05-19 14:28:25 PDT
Committed r261886: <https://trac.webkit.org/changeset/261886> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399767 [details].
Radar WebKit Bug Importer
Comment 4 2020-05-19 14:29:13 PDT
<rdar://problem/63414754>
Note You need to log in before you can comment on or make changes to this bug.