Bug 212095

Summary: Make union initializers for JSC::PropertySlot more explicit about which field is being initialized
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: JavaScriptCoreAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: NEW    
Severity: Normal CC: aakash_jain, bfulgham, darin, ews-watchlist, keith_miller, mark.lam, msaboff, pvollan, saam, stephan.szabo, tzagallo
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
URL: https://en.cppreference.com/w/cpp/language/aggregate_initialization
Bug Depends on: 211267    
Bug Blocks:    
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2020-05-19 11:26:00 PDT
Make union initializers for JSC::PropertySlot more explicit on which field is being initialized. This is a follow-up to Bug 211267: REGRESSION (r154253): JSC::PropertySlot::m_attributes is uninitialized in constructor. See Bug 211267 Comment #7: <https://bugs.webkit.org/show_bug.cgi?id=211267#c7>
Attachments
Patch v1 (1.90 KB, patch)
2020-05-19 11:29 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2020-05-19 11:29:57 PDT
Created attachment 399754 [details] Patch v1
Mark Lam
Comment 2 2020-05-19 11:33:18 PDT
Comment on attachment 399754 [details] Patch v1 Neat, but the Windows bots don't seem to like this change.
David Kilzer (:ddkilzer)
Comment 3 2020-05-19 11:57:37 PDT
(In reply to Mark Lam from comment #2) > Comment on attachment 399754 [details] > Patch v1 > > Neat, but the Windows bots don't seem to like this change. Ha! C:\Buildbot\WinCairo-EWS\build\Source\JavaScriptCore\runtime\PropertySlot.h(389): error C7555: use of designated initializers requires at least '/std:c++latest' C:\Buildbot\WinCairo-EWS\build\Source\JavaScriptCore\runtime\PropertySlot.h(404): error C7555: use of designated initializers requires at least '/std:c++latest' I guess we can hold off on this until the Windows bots add the '/std:c++latest' switch in the future.
Note You need to log in before you can comment on or make changes to this bug.