Bug 212045

Summary: Content disappears on CSS parallax example
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Simon Fraser (smfr) 2020-05-18 14:35:19 PDT
Content disappears on CSS parallax example
Comment 1 Simon Fraser (smfr) 2020-05-18 14:38:49 PDT
Created attachment 399674 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-05-18 14:38:52 PDT
<rdar://problem/63194217>
Comment 3 Dean Jackson 2020-05-18 14:42:31 PDT
Comment on attachment 399674 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399674&action=review

> Source/WebCore/platform/graphics/FloatPoint3D.h:136
> +    a.move(b.x(), b.y());

Wonder if move should return *self?

> Source/WebCore/platform/graphics/FloatPoint3D.h:159
> +    return FloatPoint3D(a.x() + b.x(), a.y() + b.y(), a.z());

What about z?

> Source/WebCore/platform/graphics/FloatPoint3D.h:169
> +    return FloatPoint3D(a.x() - b.x(), a.y() - b.y(), a.z());

Ditto?
Comment 4 Simon Fraser (smfr) 2020-05-18 16:11:13 PDT
https://trac.webkit.org/changeset/261837/webkit