Bug 212024

Summary: Allow calling VideoSampleObserver::videoSampleAvailable from a background thread
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hta, jacob_uphoff, jer.noble, philipj, pnormand, sergio, tommyw, vjaquez, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing
none
Patch none

youenn fablet
Reported 2020-05-18 07:44:00 PDT
Allow calling VideoSampleObserver::videoSampleAvailable from a background thread
Attachments
Patch (11.29 KB, patch)
2020-05-18 07:50 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.64 KB, patch)
2020-05-19 01:45 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.62 KB, patch)
2020-05-19 03:55 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (12.71 KB, patch)
2020-05-20 00:06 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-05-18 07:50:16 PDT
Created attachment 399646 [details] Patch
Eric Carlson
Comment 2 2020-05-18 08:25:11 PDT
Comment on attachment 399646 [details] Patch r=me if the bots are happy
youenn fablet
Comment 3 2020-05-19 01:45:58 PDT
Created attachment 399725 [details] Patch for landing
youenn fablet
Comment 4 2020-05-19 03:55:27 PDT
Created attachment 399727 [details] Patch for landing
EWS
Comment 5 2020-05-19 06:57:54 PDT
Committed r261856: <https://trac.webkit.org/changeset/261856> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399727 [details].
Radar WebKit Bug Importer
Comment 6 2020-05-19 06:58:17 PDT
<rdar://problem/63393480>
Jacob Uphoff
Comment 7 2020-05-19 16:36:05 PDT
Reverted r261856 for reason: This caused internal assertion failures. Committed r261893: <https://trac.webkit.org/changeset/261893>
youenn fablet
Comment 8 2020-05-20 00:01:22 PDT
I cannot repro but from the log, it seems we should check whether the active video track is null or not, given we are calling processNewSample asynchronously.
youenn fablet
Comment 9 2020-05-20 00:06:07 PDT
Created attachment 399818 [details] Patch
EWS
Comment 10 2020-05-20 00:54:10 PDT
Committed r261908: <https://trac.webkit.org/changeset/261908> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399818 [details].
Note You need to log in before you can comment on or make changes to this bug.