Bug 212011

Summary:

Clean up media controls content for Apple platforms

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Media

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, graouts, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Antoine Quint 2020-05-18 01:28:27 PDT

Clean up media controls content for Apple platforms

Comment 1 Antoine Quint 2020-05-18 01:30:25 PDT

Created attachment 399630 [details]
Patch

Comment 2 Antoine Quint 2020-05-18 01:30:31 PDT

<rdar://problem/63298588>

Comment 3 Antoine Quint 2020-05-18 02:21:21 PDT

Created attachment 399635 [details]
Patch

Comment 4 Dean Jackson 2020-05-18 03:26:59 PDT

Comment on attachment 399635 [details]
Patch

can you remove the old media controls from the framework too?

Comment 5 Antoine Quint 2020-05-18 03:28:56 PDT

(In reply to Dean Jackson from comment #4)
> Comment on attachment 399635 [details]
> Patch
> 
> can you remove the old media controls from the framework too?

We need to keep copying the legacy media controls files because a number of media tests rely on them and have not been updated for modern media controls.

Comment 6 EWS 2020-05-18 03:29:58 PDT

Committed r261805: <https://trac.webkit.org/changeset/261805>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399635 [details].