Bug 211924

Summary:

Regression(r261163) Causes crashes on builds without libwebrtc.dylib

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Media

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson, ggaren, jer.noble, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

211290

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2020-05-14 14:59:55 PDT

r261163 Causes crashes on builds without libwebrtc.dylib:
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   dyld                          	0x000000010ce8040a __abort_with_payload + 10
1   dyld                          	0x000000010cea9206 abort_with_payload + 9
2   dyld                          	0x000000010ce2bbc1 dyld::halt(char const*) + 473
3   dyld                          	0x000000010ce2bceb dyld::fastBindLazySymbol(ImageLoader**, unsigned long) + 167
4   libdyld.dylib                 	0x000000010dd6bc26 dyld_stub_binder + 282
5   com.apple.WebKit              	0x00000001076479f7 WebKit::NetworkProcessConnection::NetworkProcessConnection(IPC::Connection::Identifier, WebCore::HTTPCookieAcceptPolicy) + 161
6   com.apple.WebKit              	0x000000010712c5b5 WebKit::WebProcess::ensureNetworkProcessConnection() + 363
7   com.apple.WebKit              	0x00000001075fd695 WebKit::WebProcess::initializeWebProcess(WebKit::WebProcessCreationParameters&&) + 83
8   com.apple.WebKit              	0x00000001077960a5 WebKit::WebProcess::didReceiveWebProcessMessage(IPC::Connection&, IPC::Decoder&) + 9913
9   com.apple.WebKit              	0x000000010719f702 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) + 650
10  com.apple.WebKit              	0x00000001071a1fb4 WTF::Detail::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_7, void>::call() + 214
11  com.apple.JavaScriptCore      	0x000000011997b68d WTF::RunLoop::performWork() + 637
12  com.apple.JavaScriptCore      	0x000000011997b87a WTF::RunLoop::performWork(void*) + 26

Comment 1 Chris Dumez 2020-05-14 15:00:07 PDT

<rdar://problem/63206792>

Comment 2 Chris Dumez 2020-05-14 15:00:42 PDT

Created attachment 399415 [details]
Patch

Comment 3 Chris Dumez 2020-05-14 16:18:56 PDT

Comment on attachment 399415 [details]
Patch

Clearing flags on attachment: 399415

Committed r261719: <https://trac.webkit.org/changeset/261719>

Comment 4 Chris Dumez 2020-05-14 16:18:58 PDT

All reviewed patches have been landed.  Closing bug.