Bug 211903

Summary: run-webkit-tests shouldn't need Xcode to run Mac tests
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, ews-watchlist, glenn, ryanhaddad, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jonathan Bedard
Reported 2020-05-14 10:02:41 PDT
A number of commands in run-webkit-tests require Xcode when running on Mac, despite the fact that actually running layout tests doesn't require Xcode.
Attachments
Patch (3.28 KB, patch)
2020-05-14 10:06 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (2.51 KB, patch)
2020-05-14 11:24 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (3.81 KB, patch)
2020-05-14 14:40 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2020-05-14 10:03:10 PDT
<rdar://problem/63205839>
Jonathan Bedard
Comment 2 2020-05-14 10:06:30 PDT
Created attachment 399373 [details] Patch
Alexey Proskuryakov
Comment 3 2020-05-14 10:12:09 PDT
Comment on attachment 399373 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399373&action=review > Tools/Scripts/webkitpy/common/system/platforminfo.py:169 > + self._executive.run_command(['xcrun', '--version']) I don't think that this is going to fail in all configurations that we care about.
Jonathan Bedard
Comment 4 2020-05-14 11:24:23 PDT
Created attachment 399381 [details] Patch
Stephanie Lewis
Comment 5 2020-05-14 12:10:03 PDT
Comment on attachment 399381 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399381&action=review > Tools/Scripts/webkitpy/common/system/platforminfo.py:181 > raise NotImplementedError This seems like a change in behavior that could cause an exception. For my own understanding Is there any chance this could be called in cases where there is no Xcode installed and it wouldn't be a hard failure?
Jonathan Bedard
Comment 6 2020-05-14 13:10:50 PDT
(In reply to Stephanie Lewis from comment #5) > Comment on attachment 399381 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=399381&action=review > > > Tools/Scripts/webkitpy/common/system/platforminfo.py:181 > > raise NotImplementedError > > This seems like a change in behavior that could cause an exception. For my > own understanding Is there any chance this could be called in cases where > there is no Xcode installed and it wouldn't be a hard failure? From what I've seen, if you don't have a macosx SDK, you won't have xcodebuild anyways, so the next command will fail with an exception. The only thing we're changing here is the exception raised.
Jonathan Bedard
Comment 7 2020-05-14 14:40:53 PDT
Created attachment 399413 [details] Patch
EWS
Comment 8 2020-05-14 16:38:27 PDT
Committed r261722: <https://trac.webkit.org/changeset/261722> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399413 [details].
Note You need to log in before you can comment on or make changes to this bug.