Bug 211857

Summary: Remove unnecessary assert in {WebAccessibilityObjectWrapper attachmentView].
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Andres Gonzalez 2020-05-13 12:20:54 PDT
Remove unnecessary assert in {WebAccessibilityObjectWrapper attachmentView].
Comment 1 Andres Gonzalez 2020-05-13 12:25:20 PDT
Created attachment 399287 [details]
Patch
Comment 2 chris fleizach 2020-05-13 12:46:51 PDT
Comment on attachment 399287 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399287&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:560
> +        auto *backingObject = protectedSelf.get().axBackingObject;

I think this * is on the wrong side
Comment 3 Andres Gonzalez 2020-05-13 13:12:56 PDT
Created attachment 399291 [details]
Patch
Comment 4 Andres Gonzalez 2020-05-13 13:14:25 PDT
(In reply to chris fleizach from comment #2)
> Comment on attachment 399287 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=399287&action=review
> 
> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:560
> > +        auto *backingObject = protectedSelf.get().axBackingObject;
> 
> I think this * is on the wrong side

Fixed.
Comment 5 EWS 2020-05-13 13:51:56 PDT
Committed r261653: <https://trac.webkit.org/changeset/261653>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399291 [details].
Comment 6 Radar WebKit Bug Importer 2020-05-13 13:52:13 PDT
<rdar://problem/63198631>