Bug 211857 - Remove unnecessary assert in {WebAccessibilityObjectWrapper attachmentView].
Summary: Remove unnecessary assert in {WebAccessibilityObjectWrapper attachmentView].
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-13 12:20 PDT by Andres Gonzalez
Modified: 2020-05-13 13:52 PDT (History)
9 users (show)

See Also:


Attachments
Patch (2.09 KB, patch)
2020-05-13 12:25 PDT, Andres Gonzalez
no flags Details | Formatted Diff | Diff
Patch (2.09 KB, patch)
2020-05-13 13:12 PDT, Andres Gonzalez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2020-05-13 12:20:54 PDT
Remove unnecessary assert in {WebAccessibilityObjectWrapper attachmentView].
Comment 1 Andres Gonzalez 2020-05-13 12:25:20 PDT
Created attachment 399287 [details]
Patch
Comment 2 chris fleizach 2020-05-13 12:46:51 PDT
Comment on attachment 399287 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399287&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:560
> +        auto *backingObject = protectedSelf.get().axBackingObject;

I think this * is on the wrong side
Comment 3 Andres Gonzalez 2020-05-13 13:12:56 PDT
Created attachment 399291 [details]
Patch
Comment 4 Andres Gonzalez 2020-05-13 13:14:25 PDT
(In reply to chris fleizach from comment #2)
> Comment on attachment 399287 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=399287&action=review
> 
> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:560
> > +        auto *backingObject = protectedSelf.get().axBackingObject;
> 
> I think this * is on the wrong side

Fixed.
Comment 5 EWS 2020-05-13 13:51:56 PDT
Committed r261653: <https://trac.webkit.org/changeset/261653>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399291 [details].
Comment 6 Radar WebKit Bug Importer 2020-05-13 13:52:13 PDT
<rdar://problem/63198631>