Bug 211856

Summary: media/video-poster-set-after-playback.html is a flaky failure
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Eric Carlson <eric.carlson>
Status: REOPENED ---    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=211464
Attachments:
Description Flags
Patch
none
Spell good
none
Patch
none
Patch none

Description Ryan Haddad 2020-05-13 12:09:14 PDT 
media/video-poster-set-after-playback.html is a flaky failure

--- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/media/video-poster-set-after-playback-expected.txt
+++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/media/video-poster-set-after-playback-actual.txt
@@ -1,6 +1,6 @@
 
 EVENT(playing)
 EVENT(pause)
-EXPECTED (internals.elementShouldDisplayPosterImage(video) == 'false') OK
+EXPECTED (internals.elementShouldDisplayPosterImage(video) == 'false'), OBSERVED 'true' FAIL
 END OF TEST
 

The test fails very frequently on Catalina and Mojave, and intermittently on iOS.

https://results.webkit.org/?suite=layout-tests&test=media%2Fvideo-poster-set-after-playback.html
Comment 1 Ryan Haddad 2020-05-13 12:10:03 PDT 
This test was added yesterday with https://trac.webkit.org/changeset/261576
Comment 2 Radar WebKit Bug Importer 2020-05-13 12:10:16 PDT 
<rdar://problem/63194296>
Comment 3 Eric Carlson 2020-05-13 12:51:01 PDT 
Created attachment 399289 [details]
Patch
Comment 4 Eric Carlson 2020-05-13 13:28:18 PDT 
Created attachment 399293 [details]
Spell good
Comment 5 EWS 2020-05-13 13:57:52 PDT 
Committed r261654: <https://trac.webkit.org/changeset/261654>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399293 [details].
Comment 6 Ryan Haddad 2020-05-13 16:29:42 PDT 
Looks like the test is still flaky as of r261658:

--- /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/media/video-poster-set-after-playback-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/media/video-poster-set-after-playback-actual.txt
@@ -1,6 +1,5 @@
 
 EVENT(playing)
 EVENT(pause)
-EXPECTED (internals.elementShouldDisplayPosterImage(video) == 'false') OK
 END OF TEST
Comment 7 Eric Carlson 2020-05-14 12:10:26 PDT 
That is strange failure: the test isn't timing out or failing but it is missing the logging from a test.
Comment 8 Eric Carlson 2020-05-14 13:31:36 PDT 
Created attachment 399401 [details]
Patch
Comment 9 Eric Carlson 2020-05-14 14:36:44 PDT 
Comment on attachment 399401 [details]
Patch

This getMatchedStylesForNode.html test failure is unrelated.
Comment 10 EWS 2020-05-14 16:29:47 PDT 
Committed r261721: <https://trac.webkit.org/changeset/261721>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399401 [details].
Comment 11 Ryan Haddad 2020-05-15 09:28:44 PDT 
--- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/media/video-poster-set-after-playback-expected.txt
+++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/media/video-poster-set-after-playback-actual.txt
@@ -1,6 +1,6 @@
 
 EVENT(playing)
 EVENT(pause)
-EXPECTED (internals.elementShouldDisplayPosterImage(video) == 'false') OK
+FAIL: did not end fast enough
 END OF TEST
Comment 12 Eric Carlson 2020-05-15 10:16:31 PDT 
Created attachment 399491 [details]
Patch
Comment 13 EWS 2020-05-15 12:02:08 PDT 
Committed r261753: <https://trac.webkit.org/changeset/261753>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399491 [details].
Comment 14 Ryan Haddad 2020-05-15 16:28:30 PDT 
Sorry to always bring bad news, but this is still happening:

https://build.webkit.org/results/Apple-Catalina-Release-WK2-Tests/r261763%20(5585)/results.html
Comment 15 Ryan Haddad 2020-05-15 17:03:56 PDT 
Marked as flaky in r261770 so the bots will be happy.