Bug 211821

Summary:

[IWYU] Try removing redundant includes in WTF implementation files

Product:

WebKit

Reporter:

Ross Kirsling <ross.kirsling>

Component:

New Bugs

Assignee:

Ross Kirsling <ross.kirsling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, darin, don.olmstead, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, simon.fraser, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Ross Kirsling

Reported 2020-05-12 17:47:22 PDT

[IWYU] Try removing redundant includes in WTF implementation files

Attachments
Patch (32.75 KB, patch) 2020-05-12 17:47 PDT, Ross Kirsling	no flags	Details Formatted Diff Diff
Patch (32.23 KB, patch) 2020-05-12 17:58 PDT, Ross Kirsling	no flags	Details Formatted Diff Diff
Patch (31.70 KB, patch) 2020-05-12 18:07 PDT, Ross Kirsling	no flags	Details Formatted Diff Diff
Patch (32.31 KB, patch) 2020-05-12 18:20 PDT, Ross Kirsling	no flags	Details Formatted Diff Diff
Patch (31.88 KB, patch) 2020-05-12 18:39 PDT, Ross Kirsling	no flags	Details Formatted Diff Diff
Patch (31.58 KB, patch) 2020-05-12 18:56 PDT, Ross Kirsling	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Ross Kirsling

Comment 1 2020-05-12 17:47:49 PDT Comment hidden (obsolete)

Created attachment 399210 [details] Patch

Ross Kirsling

Comment 2 2020-05-12 17:55:02 PDT

An initial experiment to see whether/how include-what-you-use could be of benefit to us. Procedure: - build non-unified JSCOnly on Mac - run `iwyu_tool.py ../../Source/WTF/wtf/ -p .` from build dir - manually examine recommended removals There are a slew of unfortunate things here... - for additions, they don't seem to like indirect dependencies, which seems to be in opposition to WK style - for removals, they want "config.h" removed from every file - I'm not sure if there's a way to prune includes from *headers*, which would be way more useful ...but there are still a lot of removals here so it's pretty neat if you have the patience?

Ross Kirsling

Comment 3 2020-05-12 17:58:39 PDT Comment hidden (obsolete)

Created attachment 399213 [details] Patch

Ross Kirsling

Comment 4 2020-05-12 18:07:45 PDT Comment hidden (obsolete)

Created attachment 399214 [details] Patch

Ross Kirsling

Comment 5 2020-05-12 18:20:20 PDT Comment hidden (obsolete)

Created attachment 399216 [details] Patch

Ross Kirsling

Comment 6 2020-05-12 18:39:26 PDT Comment hidden (obsolete)

Created attachment 399219 [details] Patch