Bug 211811

Summary: The bottom value set for m_value in iterator_next should be materialized after a done getter
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Keith Miller
Reported 2020-05-12 15:53:22 PDT
The bottom value set for m_value in iterator_next should be materialized after a done getter
Attachments
Patch (2.98 KB, patch)
2020-05-12 15:58 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (4.38 KB, patch)
2020-05-12 16:21 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2020-05-12 15:58:03 PDT
Created attachment 399192 [details] Patch
Darin Adler
Comment 2 2020-05-12 16:00:33 PDT
Comment on attachment 399192 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399192&action=review > Source/JavaScriptCore/ChangeLog:13 > + * dfg/DFGByteCodeParser.cpp: > + (JSC::DFG::ByteCodeParser::parseBlock): Don’t see this change in the patch.
Keith Miller
Comment 3 2020-05-12 16:21:39 PDT
Comment on attachment 399192 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399192&action=review >> Source/JavaScriptCore/ChangeLog:13 >> + (JSC::DFG::ByteCodeParser::parseBlock): > > Don’t see this change in the patch. Whoops, I reverted my patch to test my changes to my test but forgot to put it back!
Keith Miller
Comment 4 2020-05-12 16:21:52 PDT
Created attachment 399199 [details] Patch
Saam Barati
Comment 5 2020-05-12 17:10:27 PDT
Comment on attachment 399199 [details] Patch r=me
EWS
Comment 6 2020-05-12 17:14:00 PDT
Committed r261589: <https://trac.webkit.org/changeset/261589> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399199 [details].
Radar WebKit Bug Importer
Comment 7 2020-05-12 17:21:28 PDT
<rdar://problem/63161249>
Note You need to log in before you can comment on or make changes to this bug.