| Summary: | REGRESSION(r258314): 5% regression on Membuster5 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, darin, eric.carlson, ews-watchlist, jonlee, mjs, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Jer Noble
2020-05-12 13:50:46 PDT
Created attachment 399172 [details]
Patch
Comment on attachment 399172 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399172&action=review > Source/WTF/ChangeLog:9 > + Disable HAVE(AVSAMPLEBUFFERVIDEOOUTPUT), as it caused a large regression in our Membuster5 benchmark. OK. I will note that doing this makes it sound like this is really USE(AVSAMPLEBUFFERVIDEOOUTPUT). (In reply to Darin Adler from comment #4) > Comment on attachment 399172 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=399172&action=review > > > Source/WTF/ChangeLog:9 > > + Disable HAVE(AVSAMPLEBUFFERVIDEOOUTPUT), as it caused a large regression in our Membuster5 benchmark. > > OK. I will note that doing this makes it sound like this is really > USE(AVSAMPLEBUFFERVIDEOOUTPUT). Yep. We should probably distinguish between HAVE and USE (by just using to USE). Committed r261590: <https://trac.webkit.org/changeset/261590> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399172 [details]. |