Bug 211772

Summary: Fix existing usage of final/override/virtual in JSC and WTF
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, benjamin, cdumez, cmarcelo, darin, don.olmstead, ews-watchlist, hi, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=211743
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Ross Kirsling
Reported 2020-05-11 23:23:04 PDT
Fix existing usage of final/override/virtual in JSC and WTF
Attachments
Patch (191.13 KB, patch)
2020-05-11 23:24 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (190.91 KB, patch)
2020-05-11 23:30 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (190.36 KB, patch)
2020-05-11 23:39 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (190.39 KB, patch)
2020-05-12 00:10 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2020-05-11 23:24:48 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 2 2020-05-11 23:25:36 PDT Comment hidden (obsolete)
Ross Kirsling
Comment 3 2020-05-11 23:26:35 PDT
This extends the unautomable part of bug 211743 to the areas of JSC and WTF that clang-tidy didn't have a qualm with.
Ross Kirsling
Comment 4 2020-05-11 23:30:20 PDT Comment hidden (obsolete)
Ross Kirsling
Comment 5 2020-05-11 23:35:27 PDT
(In reply to Ross Kirsling from comment #3) > This extends the unautomable part of bug 211743 to the areas of JSC and WTF > that clang-tidy didn't have a qualm with. (Er rather, this patch does include modernize-use-override autofixes for WTF too, because the previous patch just touched JSC.)
Ross Kirsling
Comment 6 2020-05-11 23:39:21 PDT
Created attachment 399105 [details] Patch
Ross Kirsling
Comment 7 2020-05-12 00:10:55 PDT
Created attachment 399106 [details] Patch
Darin Adler
Comment 8 2020-05-12 09:30:02 PDT
Comment on attachment 399106 [details] Patch Looks fine, rs=me
Ross Kirsling
Comment 9 2020-05-12 11:03:05 PDT
Comment on attachment 399106 [details] Patch Dammit, the previous patch got rolled out; guess I'll cq- for a moment to keep things in order.
EWS
Comment 10 2020-05-12 12:13:23 PDT
Committed r261569: <https://trac.webkit.org/changeset/261569> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399106 [details].
Radar WebKit Bug Importer
Comment 11 2020-05-12 12:14:17 PDT
<rdar://problem/63148140>
Note You need to log in before you can comment on or make changes to this bug.