| Summary: | [WebAuthn] Don't assume extensions always exist | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||
| Component: | WebKit Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, jiewen_tan, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 181943 | ||||||
| Attachments: |
|
||||||
|
Description
Jiewen Tan
2020-05-11 19:15:44 PDT
Created attachment 399087 [details]
Patch
Comment on attachment 399087 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399087&action=review > Source/WebKit/ChangeLog:3 > + [WebAuthn] Don't assume extensions always exist The ASSERT_NOT_REACHED implies that we do assume these extensions exist. I guess you mean don't treat this as a failure? But if this is a valid case, I would suggest not having the asserts. Comment on attachment 399087 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399087&action=review Thanks Brent for the r+. >> Source/WebKit/ChangeLog:3 >> + [WebAuthn] Don't assume extensions always exist > > The ASSERT_NOT_REACHED implies that we do assume these extensions exist. > > I guess you mean don't treat this as a failure? But if this is a valid case, I would suggest not having the asserts. It is only valid from IPC fuzzing not real world cases. That's why I do it this way. Committed r261588: <https://trac.webkit.org/changeset/261588> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399087 [details]. |