Bug 211759

Summary: Give some NetworkLoadMetrics to WebCoreNSURLSession's delegate
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, cgarcia, changseok, dino, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, fred.wang, glenn, gns, gyuyoung.kim, japhet, jer.noble, kangil.han, kondapallykalyan, menard, mmaxfield, pdr, philipj, pnormand, sabouhallawa, schenney, sergio, simon.fraser, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Alex Christensen 2020-05-11 19:00:25 PDT
Give some NetworkLoadMetrics to WebCoreNSURLSession's delegate
Comment 1 Alex Christensen 2020-05-11 19:11:12 PDT
Created attachment 399086 [details]
Patch
Comment 2 Alex Christensen 2020-05-12 09:59:54 PDT
Created attachment 399138 [details]
Patch
Comment 3 Alex Christensen 2020-05-12 10:20:12 PDT
Created attachment 399140 [details]
Patch
Comment 4 Alex Christensen 2020-05-12 11:37:49 PDT
Created attachment 399149 [details]
Patch
Comment 5 Alex Christensen 2020-05-12 12:50:16 PDT
Created attachment 399156 [details]
Patch
Comment 6 Jer Noble 2020-05-12 15:22:36 PDT
Comment on attachment 399156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399156&action=review

> Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm:44
> +    if (!fetchStart.value())

Nit: .value() is superfluous here.

> Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm:48
> +    return [NSDate dateWithTimeIntervalSince1970:fetchStart.value() + delta.value()];

Nit: If it were me, i'd have used .seconds() instead of .value(), but NBD, since those two methods are identical.
Comment 7 EWS 2020-05-12 21:15:04 PDT
Committed r261597: <https://trac.webkit.org/changeset/261597>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399156 [details].
Comment 8 Radar WebKit Bug Importer 2020-05-12 21:16:16 PDT
<rdar://problem/63168321>