Bug 211759 - Give some NetworkLoadMetrics to WebCoreNSURLSession's delegate
Summary: Give some NetworkLoadMetrics to WebCoreNSURLSession's delegate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-11 19:00 PDT by Alex Christensen
Modified: 2020-05-12 21:16 PDT (History)
28 users (show)

See Also:

Attachments
Patch (82.36 KB, patch)
2020-05-11 19:11 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (83.56 KB, patch)
2020-05-12 09:59 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (82.16 KB, patch)
2020-05-12 10:20 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (82.92 KB, patch)
2020-05-12 11:37 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (83.68 KB, patch)
2020-05-12 12:50 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-05-11 19:00:25 PDT 
Give some NetworkLoadMetrics to WebCoreNSURLSession's delegate
Comment 1 Alex Christensen 2020-05-11 19:11:12 PDT 
Created attachment 399086 [details]
Patch
Comment 2 Alex Christensen 2020-05-12 09:59:54 PDT 
Created attachment 399138 [details]
Patch
Comment 3 Alex Christensen 2020-05-12 10:20:12 PDT 
Created attachment 399140 [details]
Patch
Comment 4 Alex Christensen 2020-05-12 11:37:49 PDT 
Created attachment 399149 [details]
Patch
Comment 5 Alex Christensen 2020-05-12 12:50:16 PDT 
Created attachment 399156 [details]
Patch
Comment 6 Jer Noble 2020-05-12 15:22:36 PDT 
Comment on attachment 399156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399156&action=review

> Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm:44
> +    if (!fetchStart.value())

Nit: .value() is superfluous here.

> Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm:48
> +    return [NSDate dateWithTimeIntervalSince1970:fetchStart.value() + delta.value()];

Nit: If it were me, i'd have used .seconds() instead of .value(), but NBD, since those two methods are identical.
Comment 7 EWS 2020-05-12 21:15:04 PDT 
Committed r261597: <https://trac.webkit.org/changeset/261597>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399156 [details].
Comment 8 Radar WebKit Bug Importer 2020-05-12 21:16:16 PDT 
<rdar://problem/63168321>