Bug 211756

Summary: Fix build errors after r260992
Product: WebKit Reporter: Yoshiaki Jitsukawa <yoshiaki.jitsukawa>
Component: New BugsAssignee: Yoshiaki Jitsukawa <yoshiaki.jitsukawa>
Status: RESOLVED FIXED    
Severity: Normal CC: ashvayka, darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=211020
Attachments:
Description Flags
Patch
none
Patch none

Description Yoshiaki Jitsukawa 2020-05-11 17:23:09 PDT
Fix build errors after r260992
Comment 1 Yoshiaki Jitsukawa 2020-05-11 17:30:24 PDT
Created attachment 399072 [details]
Patch
Comment 2 Yoshiaki Jitsukawa 2020-05-11 17:37:28 PDT
I'm not 100% sure this is the best fix. Another way would be to add "JSC::" to the macros in JSObject.h.
Comment 3 Yusuke Suzuki 2020-05-11 17:58:55 PDT
Comment on attachment 399072 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399072&action=review

Nice catch! I think putting "JSC::" to JSC_TO_STRING_TAG_WITHOUT_TRANSITION is better if this macro is used in WebCore side too.

> Source/WebCore/ChangeLog:10
> +        Introduce JSC::PropertyAttribute into WebCore::JSDOMIteratorPrototype() since
> +        PropertyAttribute is used without JSC namespace specifier there
> +        by JSC_TO_STRING_TAG_WITHOUT_TRANSITION() macro.

Let's put `JSC::` to JSC_TO_STRING_TAG_WITHOUT_TRANSITION side.
Comment 4 Yoshiaki Jitsukawa 2020-05-11 18:24:09 PDT
> Let's put `JSC::` to JSC_TO_STRING_TAG_WITHOUT_TRANSITION side.

Will do. Thank you!
Comment 5 Yoshiaki Jitsukawa 2020-05-11 18:40:29 PDT
Created attachment 399082 [details]
Patch
Comment 6 Darin Adler 2020-05-11 20:33:16 PDT
Comment on attachment 399082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399082&action=review

> Source/JavaScriptCore/runtime/JSObject.h:1627
> +    JSC_NATIVE_INTRINSIC_FUNCTION(jsName, cppName, (attributes), (length), JSC::NoIntrinsic)

This is OK. Could also have written ::JSC::NoIntrinsic, which makes this work even when inside a namespace that happens to have the identifier JSC in it.
Comment 7 EWS 2020-05-11 20:52:26 PDT
Committed r261544: <https://trac.webkit.org/changeset/261544>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399082 [details].
Comment 8 Radar WebKit Bug Importer 2020-05-11 20:53:14 PDT
<rdar://problem/63119218>